components/dom_distiller/content/browser/distiller_page_web_contents.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/browser/distiller_page_web_contents.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/arc/bluetooth/bluetooth_type_converters_unittest.cc ('k') | components/dom_distiller/core/distiller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/browser/distiller_page_web_contents.cc

diff --git a/components/dom_distiller/content/browser/distiller_page_web_contents.cc b/components/dom_distiller/content/browser/distiller_page_web_contents.cc

index f062063541ac9e46462512474ecee44e485f5867..0ac8f7c7b8e3b87f2d1e5254453fdf9a422b7b33 100644

--- a/components/dom_distiller/content/browser/distiller_page_web_contents.cc

+++ b/components/dom_distiller/content/browser/distiller_page_web_contents.cc

@@ -8,6 +8,7 @@

#include <utility>

#include "base/callback.h"

+#include "base/memory/ptr_util.h"

#include "base/metrics/histogram_macros.h"

#include "base/strings/utf_string_conversions.h"

#include "components/dom_distiller/content/browser/distiller_javascript_utils.h"

@@ -168,7 +169,7 @@ void DistillerPageWebContents::DidFailLoad(

content::WebContentsObserver::Observe(NULL);

DCHECK(state_ == LOADING_PAGE || state_ == EXECUTING_JAVASCRIPT);

state_ = PAGELOAD_FAILED;

- std::unique_ptr<base::Value> empty = base::Value::CreateNullValue();

+ auto empty = base::MakeUnique<base::Value>();

OnWebContentsDistillationDone(GURL(), base::TimeTicks(), empty.get());

}