Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.cc
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
index e6b90a7e03fdd691d85d6f7e3aea5d94b0e4ee06..b4a3013e8e1527d023889aca8ec961033a2c59b7 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
@@ -11,6 +11,7 @@
#include "base/android/event_log.h"
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
+#include "base/memory/ptr_util.h"
#include "content/browser/android/java/gin_java_script_to_java_types_coercion.h"
#include "content/browser/android/java/java_method.h"
#include "content/browser/android/java/jni_helper.h"
@@ -325,7 +326,7 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
}
ScopedJavaLocalRef<jobject> scoped_java_object(env, java_object);
if (!scoped_java_object.obj()) {
- result_wrapper.Append(base::Value::CreateNullValue());
+ result_wrapper.Append(base::MakeUnique<base::Value>());
break;
}
SetObjectResult(scoped_java_object, object_->GetSafeAnnotationClass());

Powered by Google App Engine
This is Rietveld 408576698