Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2516)

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/server/http_handler.cc
diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc
index af0c443b22fb6542d07084f487a7f7092284518c..972e46931b69dc9c1c0948248a77fc6680dd8298 100644
--- a/chrome/test/chromedriver/server/http_handler.cc
+++ b/chrome/test/chromedriver/server/http_handler.cc
@@ -15,6 +15,7 @@
#include "base/json/json_writer.h"
#include "base/logging.h" // For CHECK macros.
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
@@ -756,7 +757,7 @@ std::unique_ptr<net::HttpServerResponseInfo> HttpHandler::PrepareLegacyResponse(
value.reset(error.release());
}
if (!value)
- value = base::Value::CreateNullValue();
+ value = base::MakeUnique<base::Value>();
base::DictionaryValue body_params;
body_params.SetInteger("status", status.code());
@@ -819,7 +820,7 @@ HttpHandler::PrepareStandardResponse(
}
if (!value)
- value = base::Value::CreateNullValue();
+ value = base::MakeUnique<base::Value>();
base::DictionaryValue body_params;
if (status.IsError()){
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | components/arc/bluetooth/bluetooth_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698