Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/gn/desc_builder.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/desc_builder.cc
diff --git a/tools/gn/desc_builder.cc b/tools/gn/desc_builder.cc
index c04fad6d18170aaecebcfeb1e1164adda303aefa..965ec921f10a12be760ee51aba699debb71b5a23 100644
--- a/tools/gn/desc_builder.cc
+++ b/tools/gn/desc_builder.cc
@@ -122,17 +122,17 @@ class BaseDescBuilder {
}
ValuePtr RenderValue(const std::string& s, bool optional = false) {
- return (s.empty() && optional) ? base::Value::CreateNullValue()
+ return (s.empty() && optional) ? base::MakeUnique<base::Value>()
: ValuePtr(new base::Value(s));
}
ValuePtr RenderValue(const SourceDir& d) {
- return d.is_null() ? base::Value::CreateNullValue()
+ return d.is_null() ? base::MakeUnique<base::Value>()
: ValuePtr(new base::Value(FormatSourceDir(d)));
}
ValuePtr RenderValue(const SourceFile& f) {
- return f.is_null() ? base::Value::CreateNullValue()
+ return f.is_null() ? base::MakeUnique<base::Value>()
: ValuePtr(new base::Value(f.value()));
}

Powered by Google App Engine
This is Rietveld 408576698