Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(693)

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Created:
9 months, 2 weeks ago by perezju
Modified:
9 months, 2 weeks ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, jam, dcheng, hansberry+watch-tether_chromium.org, media-router+watch_chromium.org, jhawkins+watch-tether_chromium.org, darin-cc_chromium.org, telemetry-reviews_chromium.org, piman+watch_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry refactor] Drop "2" from method calls to JS API Old interface has been removed, clients can switch back to the usual method names that now implement the new interface. BUG=catapult:#3028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2719853003 Cr-Commit-Position: refs/heads/master@{#453555} Committed: https://chromium.googlesource.com/chromium/src/+/d42421bec3f31371e904543c9e60b287dd3580ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -385 lines) Patch
M chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py View 5 chunks +7 lines, -7 lines 0 comments Download
M components/proximity_auth/e2e_test/cros.py View 15 chunks +32 lines, -32 lines 0 comments Download
M content/test/gpu/gpu_tests/context_lost_integration_test.py View 8 chunks +9 lines, -9 lines 0 comments Download
M content/test/gpu/gpu_tests/depth_capture_integration_test.py View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process_integration_test.py View 8 chunks +17 lines, -17 lines 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/maps_integration_test.py View 4 chunks +4 lines, -4 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_integration_test.py View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync_integration_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/trace_integration_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 4 chunks +7 lines, -7 lines 0 comments Download
M tools/chrome_proxy/common/chrome_proxy_measurements.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 7 chunks +7 lines, -7 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 8 chunks +26 lines, -26 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/live_tests/chrome_proxy_measurements.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/chrome_proxy/live_tests/chrome_proxy_metrics.py View 1 chunk +11 lines, -11 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/jetstream.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/media.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/oortonline.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/service_worker.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/spaceport.py View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/benchmarks/speedometer.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/blink_style.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/image_decoding.py View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/measurements/multipage_skpicture_printer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/measurements/skpicture_printer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/loading.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/media.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/metrics/startup_metric.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/metrics/webrtc_stats.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/webrtc_stats_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/blank_page.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/blink_memory_mobile.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/blob_workshop.py View 2 chunks +10 lines, -10 lines 0 comments Download
M tools/perf/page_sets/dummy_story_set.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/google_pages.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/image_decoding_measurement.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/indexeddb_endure_page.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/infinite_scroll_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_desktop_move_cases.py View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/perf/page_sets/key_desktop_sites.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/key_hit_test_cases.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_pages.py View 10 chunks +11 lines, -11 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_smooth.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 12 chunks +23 lines, -23 lines 0 comments Download
M tools/perf/page_sets/login_helpers/chrome_login.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/login_helpers/dropbox_login.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/login_helpers/google_login.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/login_helpers/login_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/mobile_infinite_scroll_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/mobile_memory.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/mse_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/oortonline.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/polymer.py View 7 chunks +10 lines, -10 lines 0 comments Download
M tools/perf/page_sets/repaint_helpers.py View 4 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/page_sets/service_worker_micro_benchmark.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/system_health/background_stories.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/system_health/blank_stories.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/system_health/loading_stories.py View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/perf/page_sets/system_health/long_running_stories.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/system_health/media_stories.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/text_selection_sites.py View 5 chunks +12 lines, -12 lines 0 comments Download
M tools/perf/page_sets/todomvc.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/top_10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_25_smooth.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/perf/page_sets/top_pages.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/tough_ad_cases.py View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_canvas_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_energy_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_filters_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_image_decode_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_path_rendering_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_pinch_zoom_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/tough_webgl_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/typical_10_mobile.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/typical_25.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 8 chunks +13 lines, -13 lines 0 comments Download
M tools/perf/profile_creators/fast_navigation_profile_extender.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
perezju
Hi again! Just looking for some quick stamps now. The change this time is basically ...
9 months, 2 weeks ago (2017-02-27 14:28:20 UTC) #5
Tim Song
components/proximity_auth LGTM
9 months, 2 weeks ago (2017-02-27 20:53:08 UTC) #8
RyanSturm
tools/chrome_proxy lgtm
9 months, 2 weeks ago (2017-02-27 20:58:32 UTC) #9
nednguyen
lgtm
9 months, 2 weeks ago (2017-02-27 22:29:00 UTC) #10
imcheng
media_router lgtm
9 months, 2 weeks ago (2017-02-27 23:36:55 UTC) #11
Ken Russell (switch to Gerrit)
content/test/gpu lgtm
9 months, 2 weeks ago (2017-02-27 23:52:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719853003/1
9 months, 2 weeks ago (2017-02-28 09:32:50 UTC) #14
commit-bot: I haz the power
9 months, 2 weeks ago (2017-02-28 09:41:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d42421bec3f31371e904543c9e60...

Powered by Google App Engine
This is Rietveld 0eb02b776