Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: tools/perf/page_sets/blink_memory_mobile.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/blank_page.py ('k') | tools/perf/page_sets/blob_workshop.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/blink_memory_mobile.py
diff --git a/tools/perf/page_sets/blink_memory_mobile.py b/tools/perf/page_sets/blink_memory_mobile.py
index 1e0ad6c2c19c583bac781a4649d0992b1d348b0a..e6c53c948feeafe8d8b30749db3892e4a8eeb98b 100644
--- a/tools/perf/page_sets/blink_memory_mobile.py
+++ b/tools/perf/page_sets/blink_memory_mobile.py
@@ -47,11 +47,11 @@ class TheVergePage(BlinkMemoryMobilePage):
def RunPageInteractions(self, action_runner):
action_runner.WaitForElement(selector=TheVergePage.COMMENT_LINK_SELECTOR)
- action_runner.ExecuteJavaScript2(
+ action_runner.ExecuteJavaScript(
'window.location.hash = "comments"')
action_runner.TapElement(
selector=TheVergePage.COMMENT_LINK_SELECTOR)
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'window.Chorus.Comments.collection.length > 0')
super(TheVergePage, self).RunPageInteractions(action_runner)
@@ -65,7 +65,7 @@ class FacebookPage(BlinkMemoryMobilePage):
def RunNavigateSteps(self, action_runner):
super(FacebookPage, self).RunNavigateSteps(action_runner)
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'document.getElementById("u_0_c") !== null &&'
'document.body.scrollHeight > window.innerHeight')
@@ -82,7 +82,7 @@ class GmailPage(BlinkMemoryMobilePage):
self.credentials_path)
super(GmailPage, self).RunNavigateSteps(action_runner)
action_runner.WaitForElement(selector='#apploadingdiv')
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'document.querySelector("#apploadingdiv").style.opacity == "0"')
« no previous file with comments | « tools/perf/page_sets/blank_page.py ('k') | tools/perf/page_sets/blob_workshop.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698