tools/perf/page_sets/dummy_story_set.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/dummy_story_set.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/dummy_story_set.py

diff --git a/tools/perf/page_sets/dummy_story_set.py b/tools/perf/page_sets/dummy_story_set.py

index 15ce7883fcfc59d5626fc403f28f388dd3d43b6f..c3fe05c6a73f5434e5e6f4d1c92ea52f68f0ca51 100644

--- a/tools/perf/page_sets/dummy_story_set.py

+++ b/tools/perf/page_sets/dummy_story_set.py

@@ -13,7 +13,7 @@ class DummyPage(page_module.Page):

page_set=page_set)

def RunPageInteractions(self, action_runner):

- assert action_runner.EvaluateJavaScript2('1 + window.__dummy_value') == 2

+ assert action_runner.EvaluateJavaScript('1 + window.__dummy_value') == 2

class BrokenDummyPage(page_module.Page):

@@ -26,7 +26,7 @@ class BrokenDummyPage(page_module.Page):

def RunPageInteractions(self, action_runner):

# The call below should raise an AssertionError

- assert action_runner.EvaluateJavaScript2('1 + window.__dummy_value') == 3

+ assert action_runner.EvaluateJavaScript('1 + window.__dummy_value') == 3

class DummyStorySet(story.StorySet):

« no previous file with comments | « tools/perf/page_sets/blob_workshop.py ('k') | tools/perf/page_sets/google_pages.py » ('j') | no next file with comments »