tools/perf/benchmarks/media.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/media.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/media.py

diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py

index 02ae46dfdbde335d2103d33ee5fae351512c94bc..4ba2e0a1efe931b57e11c35b8c09c3232b6ec115 100644

--- a/tools/perf/benchmarks/media.py

+++ b/tools/perf/benchmarks/media.py

@@ -20,7 +20,7 @@ class _MSEMeasurement(legacy_page_test.LegacyPageTest):

def ValidateAndMeasurePage(self, page, tab, results):

del page # unused

- media_metric = tab.EvaluateJavaScript2('window.__testMetrics')

+ media_metric = tab.EvaluateJavaScript('window.__testMetrics')

trace = media_metric['id'] if 'id' in media_metric else None

metrics = media_metric['metrics'] if 'metrics' in media_metric else []

for m in metrics:

« no previous file with comments | « tools/perf/benchmarks/kraken.py ('k') | tools/perf/benchmarks/octane.py » ('j') | no next file with comments »