tools/perf/page_sets/mobile_memory.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/mobile_memory.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/mobile_memory.py

diff --git a/tools/perf/page_sets/mobile_memory.py b/tools/perf/page_sets/mobile_memory.py

index 268a848c9f0f30e9c1d22b56244cbe4c6057be67..4357d10f0d2f2da57b3d1a00fdc38f22336b1d2b 100644

--- a/tools/perf/page_sets/mobile_memory.py

+++ b/tools/perf/page_sets/mobile_memory.py

@@ -59,7 +59,7 @@ class GoogleSearchPage(MobileMemoryPage):

action_runner.Wait(3)

with action_runner.CreateGestureInteraction('ScrollAction'):

action_runner.ScrollPage()

- action_runner.WaitForJavaScriptCondition2(

+ action_runner.WaitForJavaScriptCondition(

'document.getElementById("rg_s").childElementCount > 300')