tools/perf/page_sets/system_health/background_stories.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/background_stories.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/system_health/background_stories.py

diff --git a/tools/perf/page_sets/system_health/background_stories.py b/tools/perf/page_sets/system_health/background_stories.py

index b55eb7006ca7cddf297dd7e3f6364264aa9f4b24..59b4c132394bb92724a89d2f35dbdb8c8aea7e3e 100644

--- a/tools/perf/page_sets/system_health/background_stories.py

+++ b/tools/perf/page_sets/system_health/background_stories.py

@@ -58,7 +58,7 @@ class BackgroundNytimesMobileStory(_BackgroundStory):

action_runner.WaitForElement(selector='#additional-content button')

action_runner.ScrollPageToElement(selector='#additional-content button')

# TapElement seems flaky here so use JavaScript instead.

- action_runner.ExecuteJavaScript2(

+ action_runner.ExecuteJavaScript(

'document.querySelector("#additional-content button").click()')

# Scroll to video, start it and then wait for a few seconds.