tools/perf/page_sets/service_worker_micro_benchmark.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/service_worker_micro_benchmark.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/service_worker_micro_benchmark.py

diff --git a/tools/perf/page_sets/service_worker_micro_benchmark.py b/tools/perf/page_sets/service_worker_micro_benchmark.py

index 87fe43518389315b057e653436b2bfd2ada56719..21f1c8e1f21478c6d4a2f37105b759a81114a509 100644

--- a/tools/perf/page_sets/service_worker_micro_benchmark.py

+++ b/tools/perf/page_sets/service_worker_micro_benchmark.py

@@ -11,7 +11,7 @@ class ServiceWorkerBenchmarkPage(page.Page):

def RunNavigateSteps(self, action_runner):

super(ServiceWorkerBenchmarkPage, self).RunNavigateSteps(action_runner)

- action_runner.WaitForJavaScriptCondition2('window.done')

+ action_runner.WaitForJavaScriptCondition('window.done')

class ServiceWorkerMicroBenchmarkPageSet(story.StorySet):