tools/perf/page_sets/indexeddb_endure_page.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/indexeddb_endure_page.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/indexeddb_endure_page.py

diff --git a/tools/perf/page_sets/indexeddb_endure_page.py b/tools/perf/page_sets/indexeddb_endure_page.py

index fdee22c6ab801459c40070efd9aa9a1e2c7e5623..80feb6ec241afd5b2985b12aad0552101b21571f 100644

--- a/tools/perf/page_sets/indexeddb_endure_page.py

+++ b/tools/perf/page_sets/indexeddb_endure_page.py

@@ -15,11 +15,11 @@ class IndexedDBEndurePage(page_module.Page):

self._subtest = subtest

def RunPageInteractions(self, action_runner):

- action_runner.ExecuteJavaScript2(

+ action_runner.ExecuteJavaScript(

'window.testFilter = {{ subtest }};', subtest=self._subtest)

with action_runner.CreateInteraction('Action_Test'):

- action_runner.ExecuteJavaScript2('window.test();')

- action_runner.WaitForJavaScriptCondition2(

+ action_runner.ExecuteJavaScript('window.test();')

+ action_runner.WaitForJavaScriptCondition(

'window.done', timeout=600)

class IndexedDBEndurePageSet(story.StorySet):