tools/perf/page_sets/tough_filters_cases.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/tough_filters_cases.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/tough_filters_cases.py

diff --git a/tools/perf/page_sets/tough_filters_cases.py b/tools/perf/page_sets/tough_filters_cases.py

index 2c7bc8d5d82ffa29f868c94c44b797c87ec980fc..36b41276f978fd885a469080728a2436376dbc63 100644

--- a/tools/perf/page_sets/tough_filters_cases.py

+++ b/tools/perf/page_sets/tough_filters_cases.py

@@ -23,7 +23,7 @@ class PirateMarkPage(page_module.Page):

def RunPageInteractions(self, action_runner):

action_runner.WaitForNetworkQuiescence()

with action_runner.CreateInteraction('Filter'):

- action_runner.EvaluateJavaScript2(

+ action_runner.EvaluateJavaScript(

'document.getElementById("benchmarkButtonText").click()')

action_runner.Wait(10)