tools/perf/benchmarks/oortonline.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/oortonline.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/oortonline.py

diff --git a/tools/perf/benchmarks/oortonline.py b/tools/perf/benchmarks/oortonline.py

index 13fc7f9edd1924272c8559a16872c23409647909..2453b80e40ce0611d7d8a2d681b457161576e5a0 100644

--- a/tools/perf/benchmarks/oortonline.py

+++ b/tools/perf/benchmarks/oortonline.py

@@ -23,8 +23,8 @@ class _OortOnlineMeasurement(legacy_page_test.LegacyPageTest):

def ValidateAndMeasurePage(self, page, tab, results):

del page # unused

- tab.WaitForJavaScriptCondition2('window.benchmarkFinished', timeout=1000)

- scores = tab.EvaluateJavaScript2('window.benchmarkScore')

+ tab.WaitForJavaScriptCondition('window.benchmarkFinished', timeout=1000)

+ scores = tab.EvaluateJavaScript('window.benchmarkScore')

for score in scores:

valid = score['valid']

if valid:

« no previous file with comments | « tools/perf/benchmarks/octane.py ('k') | tools/perf/benchmarks/robohornet_pro.py » ('j') | no next file with comments »