Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/page_sets/todomvc.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/text_selection_sites.py ('k') | tools/perf/page_sets/top_10.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/todomvc.py
diff --git a/tools/perf/page_sets/todomvc.py b/tools/perf/page_sets/todomvc.py
index a03ebab11c89d56cb14fef73f5cc63b0bd98c7bd..43ce61e4f349dc61f50c4e3c173ac1f06ecec710 100644
--- a/tools/perf/page_sets/todomvc.py
+++ b/tools/perf/page_sets/todomvc.py
@@ -36,7 +36,7 @@ class TodoMVCPage(page_module.Page):
'console.time({{ label }});', label=INTERACTION_NAME)
def RunPageInteractions(self, action_runner):
- action_runner.ExecuteJavaScript2(
+ action_runner.ExecuteJavaScript(
"""
this.becameIdle = false;
this.idleCallback = function(deadline) {
@@ -48,8 +48,8 @@ class TodoMVCPage(page_module.Page):
requestIdleCallback(this.idleCallback);
"""
)
- action_runner.WaitForJavaScriptCondition2('this.becameIdle === true')
- action_runner.ExecuteJavaScript2(
+ action_runner.WaitForJavaScriptCondition('this.becameIdle === true')
+ action_runner.ExecuteJavaScript(
'console.timeEnd({{ label }});', label=INTERACTION_NAME)
« no previous file with comments | « tools/perf/page_sets/text_selection_sites.py ('k') | tools/perf/page_sets/top_10.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698