Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3831)

Unified Diff: tools/perf/measurements/rasterize_and_record_micro.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/oilpan_gc_times.py ('k') | tools/perf/measurements/skpicture_printer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/rasterize_and_record_micro.py
diff --git a/tools/perf/measurements/rasterize_and_record_micro.py b/tools/perf/measurements/rasterize_and_record_micro.py
index 3d3aaa8744042219fbcf8e05c5e72a4df064b258..1eb6426c76787e65c070162e36084b4f0145c3b0 100644
--- a/tools/perf/measurements/rasterize_and_record_micro.py
+++ b/tools/perf/measurements/rasterize_and_record_micro.py
@@ -35,7 +35,7 @@ class RasterizeAndRecordMicro(legacy_page_test.LegacyPageTest):
time.sleep(self._start_wait_time)
# Enqueue benchmark
- tab.ExecuteJavaScript2("""
+ tab.ExecuteJavaScript("""
window.benchmark_results = {};
window.benchmark_results.done = false;
window.benchmark_results.id =
@@ -53,16 +53,16 @@ class RasterizeAndRecordMicro(legacy_page_test.LegacyPageTest):
rasterize_repeat_count=self._rasterize_repeat)
# Evaluating this expression usually takes between 60 and 90 seconds.
- benchmark_id = tab.EvaluateJavaScript2(
+ benchmark_id = tab.EvaluateJavaScript(
'window.benchmark_results.id', timeout=self._timeout)
if not benchmark_id:
raise legacy_page_test.MeasurementFailure(
'Failed to schedule rasterize_and_record_micro')
- tab.WaitForJavaScriptCondition2(
+ tab.WaitForJavaScriptCondition(
'window.benchmark_results.done', timeout=self._timeout)
- data = tab.EvaluateJavaScript2('window.benchmark_results.results')
+ data = tab.EvaluateJavaScript('window.benchmark_results.results')
pixels_recorded = data['pixels_recorded']
record_time = data['record_time_ms']
« no previous file with comments | « tools/perf/measurements/oilpan_gc_times.py ('k') | tools/perf/measurements/skpicture_printer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698