tools/perf/page_sets/system_health/media_stories.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/media_stories.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/system_health/media_stories.py

diff --git a/tools/perf/page_sets/system_health/media_stories.py b/tools/perf/page_sets/system_health/media_stories.py

index c8a68ae5caa879c9338ce2858e6157539be9c2ea..ad079e8d4b515282fcec217d1b9a326dc0bcc3a8 100644

--- a/tools/perf/page_sets/system_health/media_stories.py

+++ b/tools/perf/page_sets/system_health/media_stories.py

@@ -45,7 +45,7 @@ class _MediaStory(system_health_story.SystemHealthStory):

self.PLAY_DURATION - self._GetTimeInSeconds(action_runner))

def _GetTimeInSeconds(self, action_runner):

- minutes, seconds = action_runner.EvaluateJavaScript2(

+ minutes, seconds = action_runner.EvaluateJavaScript(

'document.querySelector({{ selector }}).textContent',

selector=self.TIME_SELECTOR).split(':')

return int(minutes * 60 + seconds)