Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/chrome_proxy/live_tests/chrome_proxy_metrics.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/chrome_proxy/live_tests/chrome_proxy_measurements.py ('k') | tools/perf/benchmarks/blink_perf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/live_tests/chrome_proxy_metrics.py
diff --git a/tools/chrome_proxy/live_tests/chrome_proxy_metrics.py b/tools/chrome_proxy/live_tests/chrome_proxy_metrics.py
index 54d66d3683ec4e83903caa938c2012c1e067388e..171e56531c83cbf290582d4c40b861a75176890b 100644
--- a/tools/chrome_proxy/live_tests/chrome_proxy_metrics.py
+++ b/tools/chrome_proxy/live_tests/chrome_proxy_metrics.py
@@ -60,27 +60,27 @@ class ChromeProxyMetric(network_metrics.NetworkMetric):
# TODO(bustamante): This is a hack to workaround crbug.com/467174,
# once fixed just pull down window.performance.timing object and
# reference that everywhere.
- load_event_start = tab.EvaluateJavaScript2(
+ load_event_start = tab.EvaluateJavaScript(
'window.performance.timing.loadEventStart')
- navigation_start = tab.EvaluateJavaScript2(
+ navigation_start = tab.EvaluateJavaScript(
'window.performance.timing.navigationStart')
- dom_content_loaded_event_start = tab.EvaluateJavaScript2(
+ dom_content_loaded_event_start = tab.EvaluateJavaScript(
'window.performance.timing.domContentLoadedEventStart')
- fetch_start = tab.EvaluateJavaScript2(
+ fetch_start = tab.EvaluateJavaScript(
'window.performance.timing.fetchStart')
- request_start = tab.EvaluateJavaScript2(
+ request_start = tab.EvaluateJavaScript(
'window.performance.timing.requestStart')
- domain_lookup_end = tab.EvaluateJavaScript2(
+ domain_lookup_end = tab.EvaluateJavaScript(
'window.performance.timing.domainLookupEnd')
- domain_lookup_start = tab.EvaluateJavaScript2(
+ domain_lookup_start = tab.EvaluateJavaScript(
'window.performance.timing.domainLookupStart')
- connect_end = tab.EvaluateJavaScript2(
+ connect_end = tab.EvaluateJavaScript(
'window.performance.timing.connectEnd')
- connect_start = tab.EvaluateJavaScript2(
+ connect_start = tab.EvaluateJavaScript(
'window.performance.timing.connectStart')
- response_end = tab.EvaluateJavaScript2(
+ response_end = tab.EvaluateJavaScript(
'window.performance.timing.responseEnd')
- response_start = tab.EvaluateJavaScript2(
+ response_start = tab.EvaluateJavaScript(
'window.performance.timing.responseStart')
# NavigationStart relative markers in milliseconds.
« no previous file with comments | « tools/chrome_proxy/live_tests/chrome_proxy_measurements.py ('k') | tools/perf/benchmarks/blink_perf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698