Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: tools/perf/page_sets/top_pages.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/top_7_stress.py ('k') | tools/perf/page_sets/tough_ad_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/top_pages.py
diff --git a/tools/perf/page_sets/top_pages.py b/tools/perf/page_sets/top_pages.py
index bb758447a80d7fd7e2f0159b93df80a314e0dfa6..7f0d187b3d427b74e1b6d6e1a8b5456302c69484 100644
--- a/tools/perf/page_sets/top_pages.py
+++ b/tools/perf/page_sets/top_pages.py
@@ -59,7 +59,7 @@ class GmailPage(TopPages):
def RunNavigateSteps(self, action_runner):
super(GmailPage, self).RunNavigateSteps(action_runner)
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'window.gmonkey !== undefined &&'
'document.getElementById("gb") !== null')
@@ -80,7 +80,7 @@ class GoogleCalendarPage(TopPages):
super(GoogleCalendarPage, self).RunNavigateSteps(action_runner)
action_runner.Wait(2)
action_runner.WaitForElement('div[class~="navForward"]')
- action_runner.ExecuteJavaScript2('''
+ action_runner.ExecuteJavaScript('''
(function() {
var elem = document.createElement('meta');
elem.name='viewport';
@@ -107,7 +107,7 @@ class GoogleDocPage(TopPages):
def RunNavigateSteps(self, action_runner):
super(GoogleDocPage, self).RunNavigateSteps(action_runner)
action_runner.Wait(2)
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'document.getElementsByClassName("kix-appview-editor").length')
« no previous file with comments | « tools/perf/page_sets/top_7_stress.py ('k') | tools/perf/page_sets/tough_ad_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698