Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: tools/perf/page_sets/google_pages.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/dummy_story_set.py ('k') | tools/perf/page_sets/image_decoding_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/google_pages.py
diff --git a/tools/perf/page_sets/google_pages.py b/tools/perf/page_sets/google_pages.py
index 21aaddcab8d442e37b5d7994a1abf629f1cb51f3..abdb76a6cd71f073a55187f7388c2d44bc3fdcdd 100644
--- a/tools/perf/page_sets/google_pages.py
+++ b/tools/perf/page_sets/google_pages.py
@@ -38,7 +38,7 @@ class GmailPage(GooglePages):
google_login.LoginGoogleAccount(action_runner, 'google',
self.credentials_path)
super(GmailPage, self).RunNavigateSteps(action_runner)
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'window.gmonkey !== undefined &&'
'document.getElementById("gb") !== null')
@@ -56,7 +56,7 @@ class GoogleDocPage(GooglePages):
self.credentials_path)
super(GoogleDocPage, self).RunNavigateSteps(action_runner)
action_runner.Wait(2)
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'document.getElementsByClassName("kix-appview-editor").length')
@@ -78,5 +78,5 @@ class AdwordCampaignDesktopPage(page_module.Page):
def RunPageInteractions(self, action_runner):
action_runner.WaitForElement(text='Welcome to AdWords!')
- action_runner.ExecuteJavaScript2(
+ action_runner.ExecuteJavaScript(
'console.timeEnd({{ label }});', label=INTERACTION_NAME)
« no previous file with comments | « tools/perf/page_sets/dummy_story_set.py ('k') | tools/perf/page_sets/image_decoding_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698