Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/browsing_stories.py
diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py
index 51858efbb970f7b9b570e9acbe3db5a27287cf13..0769b2edacb66d8254373717447ae1805d1c5092 100644
--- a/tools/perf/page_sets/system_health/browsing_stories.py
+++ b/tools/perf/page_sets/system_health/browsing_stories.py
@@ -229,7 +229,7 @@ class WashingtonPostMobileStory(_NewsBrowsingStory):
# window does not have a "Close" button, instead it has only a "Send link
# to phone" button. So on tablets we run with the popup window open. The
# popup is transparent, so this is mostly an aesthetical issue.
- has_button = action_runner.EvaluateJavaScript2(
+ has_button = action_runner.EvaluateJavaScript(
'!!document.querySelector({{ selector }})',
selector=self._CLOSE_BUTTON_SELECTOR)
if has_button:
@@ -324,7 +324,7 @@ class GoogleIndiaDesktopStory(_NewsBrowsingStory):
# Refine search query in the search box.
# TODO(nednguyen): replace this with input text gesture to make it more
# realistic.
- action_runner.ExecuteJavaScript2(
+ action_runner.ExecuteJavaScript(
js_template.Render(
'document.querySelector({{ selector }}).value += "वितरण";',
selector=self._SEARCH_BOX_SELECTOR))
« no previous file with comments | « tools/perf/page_sets/system_health/blank_stories.py ('k') | tools/perf/page_sets/system_health/loading_stories.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698