Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: tools/perf/page_sets/todomvc.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/text_selection_sites.py ('k') | tools/perf/page_sets/top_10.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import page as page_module 5 from telemetry.page import page as page_module
6 from telemetry.page import shared_page_state 6 from telemetry.page import shared_page_state
7 from telemetry import story 7 from telemetry import story
8 from telemetry.util import js_template 8 from telemetry.util import js_template
9 9
10 10
(...skipping 18 matching lines...) Expand all
29 super(TodoMVCPage, self).__init__( 29 super(TodoMVCPage, self).__init__(
30 url=url, page_set=page_set, name=name, 30 url=url, page_set=page_set, name=name,
31 shared_page_state_class=shared_page_state.SharedDesktopPageState) 31 shared_page_state_class=shared_page_state.SharedDesktopPageState)
32 # TODO(jochen): This interaction does not include the 32 # TODO(jochen): This interaction does not include the
33 # WindowProxy::initialize portion before the commit. To fix this, we'll 33 # WindowProxy::initialize portion before the commit. To fix this, we'll
34 # have to migrate to TBMv2. 34 # have to migrate to TBMv2.
35 self.script_to_evaluate_on_commit = js_template.Render( 35 self.script_to_evaluate_on_commit = js_template.Render(
36 'console.time({{ label }});', label=INTERACTION_NAME) 36 'console.time({{ label }});', label=INTERACTION_NAME)
37 37
38 def RunPageInteractions(self, action_runner): 38 def RunPageInteractions(self, action_runner):
39 action_runner.ExecuteJavaScript2( 39 action_runner.ExecuteJavaScript(
40 """ 40 """
41 this.becameIdle = false; 41 this.becameIdle = false;
42 this.idleCallback = function(deadline) { 42 this.idleCallback = function(deadline) {
43 if (deadline.timeRemaining() > 20) 43 if (deadline.timeRemaining() > 20)
44 this.becameIdle = true; 44 this.becameIdle = true;
45 else 45 else
46 requestIdleCallback(this.idleCallback); 46 requestIdleCallback(this.idleCallback);
47 }; 47 };
48 requestIdleCallback(this.idleCallback); 48 requestIdleCallback(this.idleCallback);
49 """ 49 """
50 ) 50 )
51 action_runner.WaitForJavaScriptCondition2('this.becameIdle === true') 51 action_runner.WaitForJavaScriptCondition('this.becameIdle === true')
52 action_runner.ExecuteJavaScript2( 52 action_runner.ExecuteJavaScript(
53 'console.timeEnd({{ label }});', label=INTERACTION_NAME) 53 'console.timeEnd({{ label }});', label=INTERACTION_NAME)
54 54
55 55
56 class TodoMVCPageSet(story.StorySet): 56 class TodoMVCPageSet(story.StorySet):
57 57
58 """ TodoMVC examples """ 58 """ TodoMVC examples """
59 59
60 def __init__(self): 60 def __init__(self):
61 super(TodoMVCPageSet, self).__init__( 61 super(TodoMVCPageSet, self).__init__(
62 archive_data_file='data/todomvc.json', 62 archive_data_file='data/todomvc.json',
63 cloud_storage_bucket=story.PUBLIC_BUCKET) 63 cloud_storage_bucket=story.PUBLIC_BUCKET)
64 64
65 for name, url in URL_LIST: 65 for name, url in URL_LIST:
66 self.AddStory(TodoMVCPage(url, self, name)) 66 self.AddStory(TodoMVCPage(url, self, name))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/text_selection_sites.py ('k') | tools/perf/page_sets/top_10.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698