Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2778)

Unified Diff: tools/perf/metrics/media.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/metrics/loading.py ('k') | tools/perf/metrics/startup_metric.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/media.py
diff --git a/tools/perf/metrics/media.py b/tools/perf/metrics/media.py
index 4e0519f013d4b994f9ff7d8f0dbce0d95c3f6719..784113519d3c604cc728401be8ac68128a326872 100644
--- a/tools/perf/metrics/media.py
+++ b/tools/perf/metrics/media.py
@@ -23,7 +23,7 @@ class MediaMetric(Metric):
super(MediaMetric, self).__init__()
with open(os.path.join(os.path.dirname(__file__), 'media.js')) as f:
js = f.read()
- tab.ExecuteJavaScript2(js)
+ tab.ExecuteJavaScript(js)
self._results = None
self._skip_basic_metrics = False
@@ -31,10 +31,10 @@ class MediaMetric(Metric):
"""Create the media metrics for all media elements in the document."""
if hasattr(page, 'skip_basic_metrics'):
self._skip_basic_metrics = page.skip_basic_metrics
- tab.ExecuteJavaScript2('window.__createMediaMetricsForDocument()')
+ tab.ExecuteJavaScript('window.__createMediaMetricsForDocument()')
def Stop(self, page, tab):
- self._results = tab.EvaluateJavaScript2('window.__getAllMetrics()')
+ self._results = tab.EvaluateJavaScript('window.__getAllMetrics()')
# Optional |exclude_metrics| args are not in base class Metric.
# pylint: disable=arguments-differ
« no previous file with comments | « tools/perf/metrics/loading.py ('k') | tools/perf/metrics/startup_metric.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698