tools/perf/page_sets/login_helpers/chrome_login.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/login_helpers/chrome_login.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/login_helpers/chrome_login.py

diff --git a/tools/perf/page_sets/login_helpers/chrome_login.py b/tools/perf/page_sets/login_helpers/chrome_login.py

index 1be4ee23a899a3c8b25ce4692406a3d59f046c1a..33dad0fcc27159deea6d7694942dce3aead8adcc 100644

--- a/tools/perf/page_sets/login_helpers/chrome_login.py

+++ b/tools/perf/page_sets/login_helpers/chrome_login.py

@@ -44,7 +44,7 @@ def LoginChromeAccount(action_runner, credential,

raise RuntimeError('Can not find GAIA webview context for sign in.')

gaia_action_runner = action_runner_module.ActionRunner(gaia_context)

- new_flow = gaia_action_runner.EvaluateJavaScript2(

+ new_flow = gaia_action_runner.EvaluateJavaScript(

'document.querySelector("#gaia_firsform") != null')

gaia_form_id = 'gaia_firstform' if new_flow else 'gaia_loginform'

login_utils.InputForm(gaia_action_runner, account_name, input_id='Email',