tools/perf/page_sets/login_helpers/dropbox_login.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/login_helpers/dropbox_login.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/login_helpers/dropbox_login.py

diff --git a/tools/perf/page_sets/login_helpers/dropbox_login.py b/tools/perf/page_sets/login_helpers/dropbox_login.py

index a2aef275d46dd2aa43b3b4f79b0e0aa805153d03..c4f81c4fc48fe98fef1a7f796b2caa29f65ecaec 100644

--- a/tools/perf/page_sets/login_helpers/dropbox_login.py

+++ b/tools/perf/page_sets/login_helpers/dropbox_login.py

@@ -32,7 +32,7 @@ def LoginAccount(action_runner, credential,

# Wait until the "Sign in" button is enabled and then click it.

login_button_selector = '.login-form .login-button'

- action_runner.WaitForJavaScriptCondition2('''

+ action_runner.WaitForJavaScriptCondition('''

(function() {

var loginButton = document.querySelector({{ selector }});

if (!loginButton)