tools/perf/measurements/skpicture_printer.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/skpicture_printer.py

diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py

index f85562a5adb0541c5672dbca0e615304f0ff9c6c..87355b300d17c283ddd739d5a6dfbd75b7d4d4c6 100644

--- a/tools/perf/measurements/skpicture_printer.py

+++ b/tools/perf/measurements/skpicture_printer.py

@@ -28,7 +28,7 @@ class SkpicturePrinter(legacy_page_test.LegacyPageTest):

os.path.join(self._skp_outdir, page.file_safe_name))

# Replace win32 path separator char '\' with '\\'.

outpath = outpath.replace('\\', '\\\\')

- tab.EvaluateJavaScript2(

+ tab.EvaluateJavaScript(

'chrome.gpuBenchmarking.printToSkPicture({{ outpath }});',

outpath=outpath)

pictures = glob.glob(os.path.join(outpath, '*.skp'))

« no previous file with comments | « tools/perf/measurements/rasterize_and_record_micro.py ('k') | tools/perf/metrics/loading.py » ('j') | no next file with comments »