tools/perf/benchmarks/service_worker.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/service_worker.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/service_worker.py

diff --git a/tools/perf/benchmarks/service_worker.py b/tools/perf/benchmarks/service_worker.py

index f9f1250231f309b30814c194db37d96bc23df7e3..390bab57db36af5407e11286dcf0cd3d44db9a36 100644

--- a/tools/perf/benchmarks/service_worker.py

+++ b/tools/perf/benchmarks/service_worker.py

@@ -151,8 +151,8 @@ class _ServiceWorkerMicroBenchmarkMeasurement(legacy_page_test.LegacyPageTest):

def ValidateAndMeasurePage(self, page, tab, results):

del page # unused

- tab.WaitForJavaScriptCondition2('window.done', timeout=40)

- json = tab.EvaluateJavaScript2('window.results || {}')

+ tab.WaitForJavaScriptCondition('window.done', timeout=40)

+ json = tab.EvaluateJavaScript('window.results || {}')

for key, value in json.iteritems():

results.AddValue(scalar.ScalarValue(

results.current_page, key, value['units'], value['value']))

« no previous file with comments | « tools/perf/benchmarks/robohornet_pro.py ('k') | tools/perf/benchmarks/spaceport.py » ('j') | no next file with comments »