Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/chrome_proxy/live_tests/chrome_proxy_metrics.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/chrome_proxy/live_tests/chrome_proxy_measurements.py ('k') | tools/perf/benchmarks/blink_perf.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import time 6 import time
7 7
8 from common import chrome_proxy_metrics 8 from common import chrome_proxy_metrics
9 from common import network_metrics 9 from common import network_metrics
10 from common.chrome_proxy_metrics import ChromeProxyMetricException 10 from common.chrome_proxy_metrics import ChromeProxyMetricException
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 results.AddValue(scalar.ScalarValue( 53 results.AddValue(scalar.ScalarValue(
54 results.current_page, 'resources_from_cache', 'count', 54 results.current_page, 'resources_from_cache', 'count',
55 resources_from_cache)) 55 resources_from_cache))
56 results.AddValue(scalar.ScalarValue( 56 results.AddValue(scalar.ScalarValue(
57 results.current_page, 'resources_direct', 'count', resources_direct)) 57 results.current_page, 'resources_direct', 'count', resources_direct))
58 58
59 def AddResultsForLatency(self, tab, results): 59 def AddResultsForLatency(self, tab, results):
60 # TODO(bustamante): This is a hack to workaround crbug.com/467174, 60 # TODO(bustamante): This is a hack to workaround crbug.com/467174,
61 # once fixed just pull down window.performance.timing object and 61 # once fixed just pull down window.performance.timing object and
62 # reference that everywhere. 62 # reference that everywhere.
63 load_event_start = tab.EvaluateJavaScript2( 63 load_event_start = tab.EvaluateJavaScript(
64 'window.performance.timing.loadEventStart') 64 'window.performance.timing.loadEventStart')
65 navigation_start = tab.EvaluateJavaScript2( 65 navigation_start = tab.EvaluateJavaScript(
66 'window.performance.timing.navigationStart') 66 'window.performance.timing.navigationStart')
67 dom_content_loaded_event_start = tab.EvaluateJavaScript2( 67 dom_content_loaded_event_start = tab.EvaluateJavaScript(
68 'window.performance.timing.domContentLoadedEventStart') 68 'window.performance.timing.domContentLoadedEventStart')
69 fetch_start = tab.EvaluateJavaScript2( 69 fetch_start = tab.EvaluateJavaScript(
70 'window.performance.timing.fetchStart') 70 'window.performance.timing.fetchStart')
71 request_start = tab.EvaluateJavaScript2( 71 request_start = tab.EvaluateJavaScript(
72 'window.performance.timing.requestStart') 72 'window.performance.timing.requestStart')
73 domain_lookup_end = tab.EvaluateJavaScript2( 73 domain_lookup_end = tab.EvaluateJavaScript(
74 'window.performance.timing.domainLookupEnd') 74 'window.performance.timing.domainLookupEnd')
75 domain_lookup_start = tab.EvaluateJavaScript2( 75 domain_lookup_start = tab.EvaluateJavaScript(
76 'window.performance.timing.domainLookupStart') 76 'window.performance.timing.domainLookupStart')
77 connect_end = tab.EvaluateJavaScript2( 77 connect_end = tab.EvaluateJavaScript(
78 'window.performance.timing.connectEnd') 78 'window.performance.timing.connectEnd')
79 connect_start = tab.EvaluateJavaScript2( 79 connect_start = tab.EvaluateJavaScript(
80 'window.performance.timing.connectStart') 80 'window.performance.timing.connectStart')
81 response_end = tab.EvaluateJavaScript2( 81 response_end = tab.EvaluateJavaScript(
82 'window.performance.timing.responseEnd') 82 'window.performance.timing.responseEnd')
83 response_start = tab.EvaluateJavaScript2( 83 response_start = tab.EvaluateJavaScript(
84 'window.performance.timing.responseStart') 84 'window.performance.timing.responseStart')
85 85
86 # NavigationStart relative markers in milliseconds. 86 # NavigationStart relative markers in milliseconds.
87 load_start = (float(load_event_start) - navigation_start) 87 load_start = (float(load_event_start) - navigation_start)
88 results.AddValue(scalar.ScalarValue( 88 results.AddValue(scalar.ScalarValue(
89 results.current_page, 'load_start', 'ms', load_start)) 89 results.current_page, 'load_start', 'ms', load_start))
90 90
91 dom_content_loaded_start = ( 91 dom_content_loaded_start = (
92 float(dom_content_loaded_event_start) - navigation_start) 92 float(dom_content_loaded_event_start) - navigation_start)
93 results.AddValue(scalar.ScalarValue( 93 results.AddValue(scalar.ScalarValue(
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 127
128 request_duration = (float(response_start) - request_start) 128 request_duration = (float(response_start) - request_start)
129 results.AddValue(scalar.ScalarValue( 129 results.AddValue(scalar.ScalarValue(
130 results.current_page, 'request_duration', 'ms', request_duration, 130 results.current_page, 'request_duration', 'ms', request_duration,
131 important=False)) 131 important=False))
132 132
133 response_duration = (float(response_end) - response_start) 133 response_duration = (float(response_end) - response_start)
134 results.AddValue(scalar.ScalarValue( 134 results.AddValue(scalar.ScalarValue(
135 results.current_page, 'response_duration', 'ms', response_duration, 135 results.current_page, 'response_duration', 'ms', response_duration,
136 important=False)) 136 important=False))
OLDNEW
« no previous file with comments | « tools/chrome_proxy/live_tests/chrome_proxy_measurements.py ('k') | tools/perf/benchmarks/blink_perf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698