tools/perf/metrics/loading.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/loading.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/loading.py

diff --git a/tools/perf/metrics/loading.py b/tools/perf/metrics/loading.py

index ac9b51fb759809c47ed58e104ba0b4622fb42886..fa1ee3b23d3c1e4643e2414721957a688522b261 100644

--- a/tools/perf/metrics/loading.py

+++ b/tools/perf/metrics/loading.py

@@ -18,7 +18,7 @@ class LoadingMetric(Metric):

raise NotImplementedError()

def AddResults(self, tab, results):

- load_timings = tab.EvaluateJavaScript2('window.performance.timing')

+ load_timings = tab.EvaluateJavaScript('window.performance.timing')

# NavigationStart relative markers in milliseconds.

load_start = (

« no previous file with comments | « tools/perf/measurements/skpicture_printer.py ('k') | tools/perf/metrics/media.py » ('j') | no next file with comments »