Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: tools/chrome_proxy/live_tests/chrome_proxy_measurements.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 6
7 import chrome_proxy_metrics as metrics 7 import chrome_proxy_metrics as metrics
8 from common import chrome_proxy_measurements as measurements 8 from common import chrome_proxy_measurements as measurements
9 from telemetry.core import exceptions 9 from telemetry.core import exceptions
10 from telemetry.page import legacy_page_test 10 from telemetry.page import legacy_page_test
11 11
12 class ChromeProxyLatencyBase(legacy_page_test.LegacyPageTest): 12 class ChromeProxyLatencyBase(legacy_page_test.LegacyPageTest):
13 """Chrome latency measurement.""" 13 """Chrome latency measurement."""
14 14
15 def __init__(self, *args, **kwargs): 15 def __init__(self, *args, **kwargs):
16 super(ChromeProxyLatencyBase, self).__init__(*args, **kwargs) 16 super(ChromeProxyLatencyBase, self).__init__(*args, **kwargs)
17 self._metrics = metrics.ChromeProxyMetric() 17 self._metrics = metrics.ChromeProxyMetric()
18 18
19 def WillNavigateToPage(self, page, tab): 19 def WillNavigateToPage(self, page, tab):
20 tab.ClearCache(force=True) 20 tab.ClearCache(force=True)
21 self._metrics.Start(page, tab) 21 self._metrics.Start(page, tab)
22 22
23 def ValidateAndMeasurePage(self, page, tab, results): 23 def ValidateAndMeasurePage(self, page, tab, results):
24 # Wait for the load event. 24 # Wait for the load event.
25 tab.WaitForJavaScriptCondition2( 25 tab.WaitForJavaScriptCondition(
26 'performance.timing.loadEventStart', timeout=300) 26 'performance.timing.loadEventStart', timeout=300)
27 self._metrics.Stop(page, tab) 27 self._metrics.Stop(page, tab)
28 self._metrics.AddResultsForLatency(tab, results) 28 self._metrics.AddResultsForLatency(tab, results)
29 29
30 30
31 class ChromeProxyLatency(ChromeProxyLatencyBase): 31 class ChromeProxyLatency(ChromeProxyLatencyBase):
32 """Chrome proxy latency measurement.""" 32 """Chrome proxy latency measurement."""
33 33
34 def __init__(self, *args, **kwargs): 34 def __init__(self, *args, **kwargs):
35 super(ChromeProxyLatency, self).__init__(*args, **kwargs) 35 super(ChromeProxyLatency, self).__init__(*args, **kwargs)
(...skipping 19 matching lines...) Expand all
55 def __init__(self, *args, **kwargs): 55 def __init__(self, *args, **kwargs):
56 super(ChromeProxyDataSavingBase, self).__init__(*args, **kwargs) 56 super(ChromeProxyDataSavingBase, self).__init__(*args, **kwargs)
57 self._metrics = metrics.ChromeProxyMetric() 57 self._metrics = metrics.ChromeProxyMetric()
58 58
59 def WillNavigateToPage(self, page, tab): 59 def WillNavigateToPage(self, page, tab):
60 tab.ClearCache(force=True) 60 tab.ClearCache(force=True)
61 self._metrics.Start(page, tab) 61 self._metrics.Start(page, tab)
62 62
63 def ValidateAndMeasurePage(self, page, tab, results): 63 def ValidateAndMeasurePage(self, page, tab, results):
64 # Wait for the load event. 64 # Wait for the load event.
65 tab.WaitForJavaScriptCondition2( 65 tab.WaitForJavaScriptCondition(
66 'performance.timing.loadEventStart', timeout=300) 66 'performance.timing.loadEventStart', timeout=300)
67 self._metrics.Stop(page, tab) 67 self._metrics.Stop(page, tab)
68 self._metrics.AddResultsForDataSaving(tab, results) 68 self._metrics.AddResultsForDataSaving(tab, results)
69 69
70 70
71 class ChromeProxyDataSaving(ChromeProxyDataSavingBase): 71 class ChromeProxyDataSaving(ChromeProxyDataSavingBase):
72 """Chrome proxy data saving measurement.""" 72 """Chrome proxy data saving measurement."""
73 73
74 def __init__(self, *args, **kwargs): 74 def __init__(self, *args, **kwargs):
75 super(ChromeProxyDataSaving, self).__init__(*args, **kwargs) 75 super(ChromeProxyDataSaving, self).__init__(*args, **kwargs)
76 76
77 def CustomizeBrowserOptions(self, options): 77 def CustomizeBrowserOptions(self, options):
78 options.AppendExtraBrowserArgs('--enable-spdy-proxy-auth') 78 options.AppendExtraBrowserArgs('--enable-spdy-proxy-auth')
79 79
80 def WillNavigateToPage(self, page, tab): 80 def WillNavigateToPage(self, page, tab):
81 measurements.WaitForViaHeader(tab) 81 measurements.WaitForViaHeader(tab)
82 super(ChromeProxyDataSaving, self).WillNavigateToPage(page, tab) 82 super(ChromeProxyDataSaving, self).WillNavigateToPage(page, tab)
83 83
84 84
85 class ChromeProxyDataSavingDirect(ChromeProxyDataSavingBase): 85 class ChromeProxyDataSavingDirect(ChromeProxyDataSavingBase):
86 """Direct connection data saving measurement.""" 86 """Direct connection data saving measurement."""
87 87
88 def __init__(self, *args, **kwargs): 88 def __init__(self, *args, **kwargs):
89 super(ChromeProxyDataSavingDirect, self).__init__(*args, **kwargs) 89 super(ChromeProxyDataSavingDirect, self).__init__(*args, **kwargs)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698