tools/perf/metrics/webrtc_stats.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/webrtc_stats.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/webrtc_stats.py

diff --git a/tools/perf/metrics/webrtc_stats.py b/tools/perf/metrics/webrtc_stats.py

index 6b64f5a43ffa5f5a1abc306935cefdd443a199ed..8c3570316cbcc6e71f944cd2157df051c5baf313 100644

--- a/tools/perf/metrics/webrtc_stats.py

+++ b/tools/perf/metrics/webrtc_stats.py

@@ -140,7 +140,7 @@ class WebRtcStatisticsMetric(Metric):

def Stop(self, page, tab):

"""Digs out stats from data populated by the javascript in webrtc_cases."""

- self._all_reports = tab.EvaluateJavaScript2(

+ self._all_reports = tab.EvaluateJavaScript(

'JSON.stringify(window.peerConnectionReports)')

def AddResults(self, tab, results):

« no previous file with comments | « tools/perf/metrics/startup_metric.py ('k') | tools/perf/metrics/webrtc_stats_unittest.py » ('j') | no next file with comments »