tools/perf/benchmarks/indexeddb_perf.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/indexeddb_perf.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/indexeddb_perf.py

diff --git a/tools/perf/benchmarks/indexeddb_perf.py b/tools/perf/benchmarks/indexeddb_perf.py

index 41847cab0775371b015686515d3024b6b264ce04..4955798d908c0e08113e7c94d4dbdf4691071e93 100644

--- a/tools/perf/benchmarks/indexeddb_perf.py

+++ b/tools/perf/benchmarks/indexeddb_perf.py

@@ -65,7 +65,7 @@ class _IndexedDbMeasurement(legacy_page_test.LegacyPageTest):

def ValidateAndMeasurePage(self, page, tab, results):

tab.WaitForDocumentReadyStateToBeComplete()

- tab.WaitForJavaScriptCondition2('window.done', timeout=600)

+ tab.WaitForJavaScriptCondition('window.done', timeout=600)

self._power_metric.Stop(page, tab)

self._memory_metric.Stop(page, tab)

@@ -73,7 +73,7 @@ class _IndexedDbMeasurement(legacy_page_test.LegacyPageTest):

self._memory_metric.AddResults(tab, results)

self._power_metric.AddResults(tab, results)

- result_dict = json.loads(tab.EvaluateJavaScript2(

+ result_dict = json.loads(tab.EvaluateJavaScript(

'JSON.stringify(automation.getResults());'))

total = 0.0

for key in result_dict:

« no previous file with comments | « tools/perf/benchmarks/dromaeo.py ('k') | tools/perf/benchmarks/jetstream.py » ('j') | no next file with comments »