Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 26190003: Potentially optimize some GrGLEffects for known input color values (Closed)

Created:
7 years, 2 months ago by Kimmo Kinnunen
Modified:
4 years, 7 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Potentially optimize some GrGLEffects for known input color values Make GrGLEffects input GrGLSLExpr<4> inputColor instead of char*. This makes it possible to skip some calculations in specific corner-cases.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -197 lines) Patch
M src/core/SkXfermode.cpp View 4 chunks +19 lines, -20 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 3 chunks +20 lines, -12 lines 0 comments Download
M src/effects/SkBitmapAlphaThresholdShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M src/effects/SkLumaXfermode.cpp View 4 chunks +15 lines, -21 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 6 chunks +98 lines, -24 lines 0 comments Download
M src/gpu/gl/GrGLSL_impl.h View 3 chunks +134 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 4 chunks +7 lines, -28 lines 0 comments Download
M src/gpu/gl/GrGLVertexEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Kimmo Kinnunen
7 years, 2 months ago (2013-10-14 14:16:42 UTC) #1
Does this get too silly?

Powered by Google App Engine
This is Rietveld 408576698