src/gpu/GrOvalRenderer.cpp - Issue 26190003: Potentially optimize some GrGLEffects for known input color values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrOvalRenderer.cpp

Issue 26190003: Potentially optimize some GrGLEffects for known input color values (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/GrOvalRenderer.cpp

diff --git a/src/gpu/GrOvalRenderer.cpp b/src/gpu/GrOvalRenderer.cpp

index 27bd74a88afae2d6fdc89eeb6629d75e525a9033..4a5631d9c349df6d78304a81617ef9f67a9bfd37 100644

--- a/src/gpu/GrOvalRenderer.cpp

+++ b/src/gpu/GrOvalRenderer.cpp

@@ -98,7 +98,7 @@ public:

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray& samplers) SK_OVERRIDE {

const CircleEdgeEffect& circleEffect = drawEffect.castEffect<CircleEdgeEffect>();

@@ -117,7 +117,7 @@ public:

}

builder->fsCodeAppendf("\t%s = %s;\n", outputColor,

- (GrGLSLExpr4(inputColor) * GrGLSLExpr1("edgeAlpha")).c_str());

+ (inputColor * GrGLSLExpr1("edgeAlpha")).c_str());

}

static inline EffectKey GenKey(const GrDrawEffect& drawEffect, const GrGLCaps&) {

@@ -209,7 +209,7 @@ public:

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray& samplers) SK_OVERRIDE {

const EllipseEdgeEffect& ellipseEffect = drawEffect.castEffect<EllipseEdgeEffect>();

@@ -249,7 +249,7 @@ public:

}

builder->fsCodeAppendf("\t%s = %s;\n", outputColor,

- (GrGLSLExpr4(inputColor) * GrGLSLExpr1("edgeAlpha")).c_str());

+ (inputColor * GrGLSLExpr1("edgeAlpha")).c_str());

}

static inline EffectKey GenKey(const GrDrawEffect& drawEffect, const GrGLCaps&) {

@@ -349,7 +349,7 @@ public:

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray& samplers) SK_OVERRIDE {

const DIEllipseEdgeEffect& ellipseEffect = drawEffect.castEffect<DIEllipseEdgeEffect>();

@@ -407,7 +407,7 @@ public:

}

builder->fsCodeAppendf("\t%s = %s;\n", outputColor,

- (GrGLSLExpr4(inputColor) * GrGLSLExpr1("edgeAlpha")).c_str());

+ (inputColor * GrGLSLExpr1("edgeAlpha")).c_str());

}

static inline EffectKey GenKey(const GrDrawEffect& drawEffect, const GrGLCaps&) {

« no previous file with comments | « src/gpu/GrAARectRenderer.cpp ('k') | src/gpu/effects/GrBezierEffect.cpp » ('j') | no next file with comments »