src/effects/gradients/SkTwoPointRadialGradient.cpp - Issue 26190003: Potentially optimize some GrGLEffects for known input color values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkTwoPointRadialGradient.cpp

Issue 26190003: Potentially optimize some GrGLEffects for known input color values (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkTwoPointRadialGradient.cpp

diff --git a/src/effects/gradients/SkTwoPointRadialGradient.cpp b/src/effects/gradients/SkTwoPointRadialGradient.cpp

index 923ed1e6ba795449eb06429664e75066e65b92f5..0b7cdc7709f64485b283f1eacbe84401bf7981ef 100644

--- a/src/effects/gradients/SkTwoPointRadialGradient.cpp

+++ b/src/effects/gradients/SkTwoPointRadialGradient.cpp

@@ -388,7 +388,7 @@ public:

const GrDrawEffect&,

EffectKey,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray&) SK_OVERRIDE;

virtual void setData(const GrGLUniformManager&, const GrDrawEffect&) SK_OVERRIDE;

@@ -542,7 +542,7 @@ void GrGLRadial2Gradient::emitCode(GrGLShaderBuilder* builder,

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray& coords,

const TextureSamplerArray& samplers) {