src/gpu/effects/GrBezierEffect.cpp - Issue 26190003: Potentially optimize some GrGLEffects for known input color values

Unified Diff: src/gpu/effects/GrBezierEffect.cpp

Issue 26190003: Potentially optimize some GrGLEffects for known input color values (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/effects/GrBezierEffect.cpp

diff --git a/src/gpu/effects/GrBezierEffect.cpp b/src/gpu/effects/GrBezierEffect.cpp

index c9a2bea0522f150fce1086639b41527952a836e4..7351ed9a0a8fd5afd047433d162fa95fbcac0cf2 100644

--- a/src/gpu/effects/GrBezierEffect.cpp

+++ b/src/gpu/effects/GrBezierEffect.cpp

@@ -20,7 +20,7 @@ public:

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray&) SK_OVERRIDE;

@@ -45,7 +45,7 @@ void GrGLConicEffect::emitCode(GrGLFullShaderBuilder* builder,

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray& samplers) {

const char *vsName, *fsName;

@@ -111,7 +111,7 @@ void GrGLConicEffect::emitCode(GrGLFullShaderBuilder* builder,

}

builder->fsCodeAppendf("\t%s = %s;\n", outputColor,

- (GrGLSLExpr4(inputColor) * GrGLSLExpr1("edgeAlpha")).c_str());

+ (inputColor * GrGLSLExpr1("edgeAlpha")).c_str());

}

GrGLEffect::EffectKey GrGLConicEffect::GenKey(const GrDrawEffect& drawEffect, const GrGLCaps&) {

@@ -161,7 +161,7 @@ public:

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray&) SK_OVERRIDE;

@@ -186,7 +186,7 @@ void GrGLQuadEffect::emitCode(GrGLFullShaderBuilder* builder,

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray& samplers) {

const char *vsName, *fsName;

@@ -239,7 +239,7 @@ void GrGLQuadEffect::emitCode(GrGLFullShaderBuilder* builder,

}

builder->fsCodeAppendf("\t%s = %s;\n", outputColor,

- (GrGLSLExpr4(inputColor) * GrGLSLExpr1("edgeAlpha")).c_str());

+ (inputColor * GrGLSLExpr1("edgeAlpha")).c_str());

builder->vsCodeAppendf("\t%s = %s;\n", vsName, attrName->c_str());

@@ -292,7 +292,7 @@ public:

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray&) SK_OVERRIDE;

@@ -317,7 +317,7 @@ void GrGLCubicEffect::emitCode(GrGLFullShaderBuilder* builder,

const GrDrawEffect& drawEffect,

EffectKey key,

const char* outputColor,

- const char* inputColor,

+ const GrGLSLExpr4& inputColor,

const TransformedCoordsArray&,

const TextureSamplerArray& samplers) {

const char *vsName, *fsName;

@@ -383,7 +383,7 @@ void GrGLCubicEffect::emitCode(GrGLFullShaderBuilder* builder,

}

builder->fsCodeAppendf("\t%s = %s;\n", outputColor,

- (GrGLSLExpr4(inputColor) * GrGLSLExpr1("edgeAlpha")).c_str());

+ (inputColor * GrGLSLExpr1("edgeAlpha")).c_str());

}

GrGLEffect::EffectKey GrGLCubicEffect::GenKey(const GrDrawEffect& drawEffect, const GrGLCaps&) {

« no previous file with comments | « src/gpu/GrOvalRenderer.cpp ('k') | src/gpu/effects/GrBicubicEffect.cpp » ('j') | no next file with comments »