Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648463003: FPs now use the correct builder types(just a rename) (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

FPs now use the correct builder types(just a rename) BUG=skia: Committed: https://skia.googlesource.com/skia/+/1598899975ecc85b003a59740b588d1ddbcedb09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -139 lines) Patch
M src/core/SkXfermode.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 18 chunks +24 lines, -24 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 15 chunks +15 lines, -15 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
joshua.litt
6 years, 2 months ago (2014-10-09 19:09:17 UTC) #2
bsalomon
nice, small change but i think it helps make this more understandable.
6 years, 2 months ago (2014-10-09 19:18:13 UTC) #3
bsalomon
lgtm
6 years, 2 months ago (2014-10-09 19:32:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648463003/1
6 years, 2 months ago (2014-10-09 21:33:39 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 22:04:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 1598899975ecc85b003a59740b588d1ddbcedb09

Powered by Google App Engine
This is Rietveld 408576698