Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Replace ASSERT with DCHECK in core/layout/ excluding subdirs

BUG=697685
Review-Url: https://codereview.chromium.org/2770123003
Cr-Commit-Position: refs/heads/master@{#461948}
Committed: https://chromium.googlesource.com/chromium/src/+/e2fa2002398888f73a3f1848a34340b37168b31a

[mrunal, 2017-03-24 00:14:41]

The CQ bit was checked by mrunal.kapade@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 00:15:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:33:10]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[mrunal, 2017-04-04 00:08:45]

Description was changed from

==========
Replace ASSERT with DCHECK in core/layout/ excluding subdirs

BUG=697685
==========

to

==========
Replace ASSERT with DCHECK in core/layout/ excluding subdirs

BUG=697685
==========

[mrunal, 2017-04-04 00:08:46]

mrunal.kapade@intel.com changed reviewers:
+ eae@chromium.org, tkent@chromium.org

[mrunal, 2017-04-04 00:09:20]

eae/tkent can you PTAL? Thanks.

[tkent, 2017-04-04 00:18:21]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 00:19:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-04-04 01:36:17]

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/BidiRunForLine.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/BidiRunForLine.cpp:113:
DCHECK(topResolver.position() != endOfLine);
Use DCHECK_NE if it doesn't cause a compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/FloatingObjects.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/FloatingObjects.cpp:513:
DCHECK(floatingObject.isPlaced() && floatingObject.isInPlacedTree());
Split this into two DCHEKs.

DCHECK(floatingObject.isPlaced());
DCHECK(floatingObject.isInPlacedTree());

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:114:
DCHECK(gPositionedContainerMap->at(descendant) == this);
Use DCHECK_EQ

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:123:
DCHECK(descendant->percentHeightContainer() == this);
Use DCHECK_EQ

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:946:
DCHECK(hasPositionedObjects() && positionedObjects()->contains(o));
Split this into two.

DCHECK(hasPositionedObjects());
DCHECK(positionedObjects()->contains(o));

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:979:
DCHECK(positionedDescendants && positionedDescendants->contains(o));
Split this into two.

DCHECK(positionedDescendants);
DCHECK(positionedDescendants->contains(o));

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:1056:
DCHECK(lastFloatIterator != end);
Use DCHECK_NE if it doesn't cause a compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:1160:
DCHECK(endOfLine != resolver.position());
Use DCHECK_NE if it doesn't cause a compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:1200:
DCHECK(resolver.position() == endOfLine);
Use DCHEK_EQ if it doesn't cause a compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:5419:
DCHECK(layoutState->layoutObject() == containerBlock);
Use DCHECK_EQ

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutCounter.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutCounter.cpp:509:
DCHECK(counterMaps().at(&child->owner())->at(identifier) == child);
Use DCHECK_EQ if it doesn't cause a compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
(right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:886:
DCHECK(it != m_multiColumnSetList.end());
Use DCHECK_NE if it doesn't cause a compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutQuote.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutQuote.cpp:47: DCHECK(!m_next &&
!m_previous);
Split this into two.

DCHECK(!m_next);
DCHECK(!m_previous);

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutQuote.cpp:314: DCHECK(!m_next &&
!m_previous);
Split this into two.

DCHECK(!m_next);
DCHECK(!m_previous);

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutTableCol.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutTableCol.cpp:124:
DCHECK(this->location() == LayoutPoint());
Use DCHECK_EQ if it doesn't cause a compile failure.

[commit-bot: I haz the power, 2017-04-04 01:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 01:44:25]

Dry run: This issue passed the CQ dry run.

[mrunal, 2017-04-05 00:39:14]

PTAL.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/BidiRunForLine.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/BidiRunForLine.cpp:113:
DCHECK(topResolver.position() != endOfLine);
On 2017/04/04 01:36:16, tkent wrote:
> Use DCHECK_NE if it doesn't cause a compile failure.

Not possible because of compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/FloatingObjects.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/FloatingObjects.cpp:513:
DCHECK(floatingObject.isPlaced() && floatingObject.isInPlacedTree());
On 2017/04/04 01:36:17, tkent wrote:
> Split this into two DCHEKs.
> 
> DCHECK(floatingObject.isPlaced());
> DCHECK(floatingObject.isInPlacedTree());

Done.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:114:
DCHECK(gPositionedContainerMap->at(descendant) == this);
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_EQ

Done.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:123:
DCHECK(descendant->percentHeightContainer() == this);
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_EQ

Done.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:946:
DCHECK(hasPositionedObjects() && positionedObjects()->contains(o));
On 2017/04/04 01:36:17, tkent wrote:
> Split this into two.
> 
> DCHECK(hasPositionedObjects());
> DCHECK(positionedObjects()->contains(o));

Done.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:979:
DCHECK(positionedDescendants && positionedDescendants->contains(o));
On 2017/04/04 01:36:17, tkent wrote:
> Split this into two.
> 
> DCHECK(positionedDescendants);
> DCHECK(positionedDescendants->contains(o));

Done.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:1056:
DCHECK(lastFloatIterator != end);
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_NE if it doesn't cause a compile failure.

Not possible because of compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:1160:
DCHECK(endOfLine != resolver.position());
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_NE if it doesn't cause a compile failure.

Not possible because of compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:1200:
DCHECK(resolver.position() == endOfLine);
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHEK_EQ if it doesn't cause a compile failure.

Not possible because of compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:5419:
DCHECK(layoutState->layoutObject() == containerBlock);
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_EQ

Not possible because of compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutCounter.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutCounter.cpp:509:
DCHECK(counterMaps().at(&child->owner())->at(identifier) == child);
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_EQ if it doesn't cause a compile failure.

Not possible because of compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
(right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:886:
DCHECK(it != m_multiColumnSetList.end());
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_NE if it doesn't cause a compile failure.

Not possible because of compile failure.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutQuote.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutQuote.cpp:47: DCHECK(!m_next &&
!m_previous);
On 2017/04/04 01:36:17, tkent wrote:
> Split this into two.
> 
> DCHECK(!m_next);
> DCHECK(!m_previous);

Done.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutQuote.cpp:314: DCHECK(!m_next &&
!m_previous);
On 2017/04/04 01:36:17, tkent wrote:
> Split this into two.
> 
> DCHECK(!m_next);
> DCHECK(!m_previous);
> 

Done.

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutTableCol.cpp (right):

https://codereview.chromium.org/2770123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutTableCol.cpp:124:
DCHECK(this->location() == LayoutPoint());
On 2017/04/04 01:36:17, tkent wrote:
> Use DCHECK_EQ if it doesn't cause a compile failure.

Not possible because of compile failure.

[tkent, 2017-04-05 00:53:40]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 00:54:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 02:29:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:29:47]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-04-05 02:30:35]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-04-05 02:30:36]

lgtm

[commit-bot: I haz the power, 2017-04-05 02:31:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 02:40:12]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491359435717090,
"parent_rev": "0eb3418b597de14bff675fde0e575fbc947ff962", "commit_rev":
"e2fa2002398888f73a3f1848a34340b37168b31a"}

[commit-bot: I haz the power, 2017-04-05 02:41:03]

Description was changed from

==========
Replace ASSERT with DCHECK in core/layout/ excluding subdirs

BUG=697685
==========

to

==========
Replace ASSERT with DCHECK in core/layout/ excluding subdirs

BUG=697685

Review-Url: https://codereview.chromium.org/2770123003
Cr-Commit-Position: refs/heads/master@{#461948}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2fa2002398888f73a3f1848a343...
==========

[commit-bot: I haz the power, 2017-04-05 02:41:05]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/e2fa2002398888f73a3f1848a343...