Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp b/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
index 67ad4dc2a81d1a010c12cc090562588c32417466..288919eb06f052f6f7e316520db60b6686321de4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
@@ -41,7 +41,7 @@ LayoutScrollbarPart::LayoutScrollbarPart(ScrollableArea* scrollableArea,
m_scrollableArea(scrollableArea),
m_scrollbar(scrollbar),
m_part(part) {
- ASSERT(m_scrollableArea);
+ DCHECK(m_scrollableArea);
}
LayoutScrollbarPart::~LayoutScrollbarPart() {
@@ -207,7 +207,7 @@ void LayoutScrollbarPart::styleDidChange(StyleDifference diff,
const ComputedStyle* oldStyle) {
LayoutBlock::styleDidChange(diff, oldStyle);
// See adjustStyleBeforeSet() above.
- ASSERT(!isOrthogonalWritingModeRoot());
+ DCHECK(!isOrthogonalWritingModeRoot());
setInline(false);
clearPositionedState();
setFloating(false);
@@ -232,7 +232,7 @@ void LayoutScrollbarPart::setNeedsPaintInvalidation() {
}
// This LayoutScrollbarPart is a scroll corner or a resizer.
- ASSERT(m_part == NoPart);
+ DCHECK_EQ(m_part, NoPart);
if (FrameView* frameView = view()->frameView()) {
if (frameView->isFrameViewScrollCorner(this)) {
frameView->setScrollCornerNeedsPaintInvalidation();

Powered by Google App Engine
This is Rietveld 408576698