Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/LayoutMultiColumnSpannerPlaceholder.h" 5 #include "core/layout/LayoutMultiColumnSpannerPlaceholder.h"
6 6
7 #include "core/layout/LayoutMultiColumnFlowThread.h" 7 #include "core/layout/LayoutMultiColumnFlowThread.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 const { 99 const {
100 return m_layoutObjectInFlowThread->minPreferredLogicalWidth(); 100 return m_layoutObjectInFlowThread->minPreferredLogicalWidth();
101 } 101 }
102 102
103 LayoutUnit LayoutMultiColumnSpannerPlaceholder::maxPreferredLogicalWidth() 103 LayoutUnit LayoutMultiColumnSpannerPlaceholder::maxPreferredLogicalWidth()
104 const { 104 const {
105 return m_layoutObjectInFlowThread->maxPreferredLogicalWidth(); 105 return m_layoutObjectInFlowThread->maxPreferredLogicalWidth();
106 } 106 }
107 107
108 void LayoutMultiColumnSpannerPlaceholder::layout() { 108 void LayoutMultiColumnSpannerPlaceholder::layout() {
109 ASSERT(needsLayout()); 109 DCHECK(needsLayout());
110 110
111 // The placeholder, like any other block level object, has its logical top 111 // The placeholder, like any other block level object, has its logical top
112 // calculated and set before layout. Copy this to the actual column-span:all 112 // calculated and set before layout. Copy this to the actual column-span:all
113 // object before laying it out, so that it gets paginated correctly, in case 113 // object before laying it out, so that it gets paginated correctly, in case
114 // we have an enclosing fragmentation context. 114 // we have an enclosing fragmentation context.
115 m_layoutObjectInFlowThread->setLogicalTop(logicalTop()); 115 m_layoutObjectInFlowThread->setLogicalTop(logicalTop());
116 116
117 // Lay out the actual column-span:all element. 117 // Lay out the actual column-span:all element.
118 m_layoutObjectInFlowThread->layoutIfNeeded(); 118 m_layoutObjectInFlowThread->layoutIfNeeded();
119 119
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 HitTestResult& result, 152 HitTestResult& result,
153 const HitTestLocation& locationInContainer, 153 const HitTestLocation& locationInContainer,
154 const LayoutPoint& accumulatedOffset, 154 const LayoutPoint& accumulatedOffset,
155 HitTestAction action) { 155 HitTestAction action) {
156 return !m_layoutObjectInFlowThread->hasSelfPaintingLayer() && 156 return !m_layoutObjectInFlowThread->hasSelfPaintingLayer() &&
157 m_layoutObjectInFlowThread->nodeAtPoint(result, locationInContainer, 157 m_layoutObjectInFlowThread->nodeAtPoint(result, locationInContainer,
158 accumulatedOffset, action); 158 accumulatedOffset, action);
159 } 159 }
160 160
161 } // namespace blink 161 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698