Replace ASSERT with DCHECK in core/layout/ excluding subdirs

third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
  * All right reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 91 matching lines @@
 }
 
 void constructBidiRunsForLine(InlineBidiResolver& topResolver,
                               BidiRunList<BidiRun>& bidiRuns,
                               const InlineIterator& endOfLine,
                               VisualDirectionOverride override,
                               bool previousLineBrokeCleanly,
                               bool isNewUBAParagraph) {
   // FIXME: We should pass a BidiRunList into createBidiRunsForLine instead
   // of the resolver owning the runs.
-  ASSERT(&topResolver.runs() == &bidiRuns);
-  ASSERT(topResolver.position() != endOfLine);
+  DCHECK_EQ(&topResolver.runs(), &bidiRuns);
+  DCHECK(topResolver.position() != endOfLine);

[tkent, 2017/04/04 01:36:16]

Use DCHECK_NE if it doesn't cause a compile failure.

[mrunal, 2017/04/05 00:39:14]

Not possible because of compile failure.

   LineLayoutItem currentRoot = topResolver.position().root();
   topResolver.createBidiRunsForLine(endOfLine, override,
                                     previousLineBrokeCleanly);
 
   while (!topResolver.isolatedRuns().isEmpty()) {
     // It does not matter which order we resolve the runs as long as we
     // resolve them all.
     BidiIsolatedRun isolatedRun = topResolver.isolatedRuns().back();
     topResolver.isolatedRuns().pop_back();
     currentRoot = isolatedRun.root;
 
     LineLayoutItem startObj = isolatedRun.object;
 
     // Only inlines make sense with unicode-bidi: isolate (blocks are
     // already isolated).
     // FIXME: Because enterIsolate is not passed a LayoutObject, we have to
     // crawl up the tree to see which parent inline is the isolate. We could
     // change enterIsolate to take a LayoutObject and do this logic there,
     // but that would be a layering violation for BidiResolver (which knows
     // nothing about LayoutObject).
     LineLayoutItem isolatedInline =
         highestContainingIsolateWithinRoot(startObj, currentRoot);
-    ASSERT(isolatedInline);
+    DCHECK(isolatedInline);
 
     InlineBidiResolver isolatedResolver;
     LineMidpointState& isolatedLineMidpointState =
         isolatedResolver.midpointState();
     isolatedLineMidpointState =
         topResolver.midpointStateForIsolatedRun(isolatedRun.runToReplace);
     UnicodeBidi unicodeBidi = isolatedInline.style()->getUnicodeBidi();
     TextDirection direction;
     if (unicodeBidi == UnicodeBidi::kPlaintext) {
       direction = determinePlaintextDirectionality(
@@ skipping 17 matching lines @@
                        isolatedRun.position);
     isolatedResolver.setPositionIgnoringNestedIsolates(iter);
     // We stop at the next end of line; we may re-enter this isolate in the
     // next call to constructBidiRuns().
     // FIXME: What should end and previousLineBrokeCleanly be?
     // rniwa says previousLineBrokeCleanly is just a WinIE hack and could
     // always be false here?
     isolatedResolver.createBidiRunsForLine(endOfLine, NoVisualOverride,
                                            previousLineBrokeCleanly);
 
-    ASSERT(isolatedResolver.runs().runCount());
+    DCHECK(isolatedResolver.runs().runCount());
     if (isolatedResolver.runs().runCount())
       bidiRuns.replaceRunWithRuns(&isolatedRun.runToReplace,
                                   isolatedResolver.runs());
 
     // If we encountered any nested isolate runs, save them for later
     // processing.
     while (!isolatedResolver.isolatedRuns().isEmpty()) {
       BidiIsolatedRun runWithContext = isolatedResolver.isolatedRuns().back();
       isolatedResolver.isolatedRuns().pop_back();
       topResolver.setMidpointStateForIsolatedRun(
           runWithContext.runToReplace,
           isolatedResolver.midpointStateForIsolatedRun(
               runWithContext.runToReplace));
       topResolver.isolatedRuns().push_back(runWithContext);
     }
   }
 }
 
 }  // namespace blink