Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutSlider.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutSlider.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutSlider.cpp b/third_party/WebKit/Source/core/layout/LayoutSlider.cpp
index 34f19534a2d5c94f027d6e09f05504a497d33161..0d709ccf01147f7e4999a1f28ef7f5a20698ae4a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutSlider.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutSlider.cpp
@@ -34,7 +34,7 @@ const int LayoutSlider::defaultTrackLength = 129;
LayoutSlider::LayoutSlider(HTMLInputElement* element)
: LayoutFlexibleBox(element) {
// We assume LayoutSlider works only with <input type=range>.
- ASSERT(element->type() == InputTypeNames::range);
+ DCHECK_EQ(element->type(), InputTypeNames::range);
}
LayoutSlider::~LayoutSlider() {}
@@ -43,7 +43,7 @@ int LayoutSlider::baselinePosition(FontBaseline,
bool /*firstLine*/,
LineDirectionMode,
LinePositionMode linePositionMode) const {
- ASSERT(linePositionMode == PositionOnContainingLine);
+ DCHECK_EQ(linePositionMode, PositionOnContainingLine);
// FIXME: Patch this function for writing-mode.
return (size().height() + marginTop()).toInt();
}

Powered by Google App Engine
This is Rietveld 408576698