Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Simon Hausmann <hausmann@kde.org> 3 * (C) 2000 Simon Hausmann <hausmann@kde.org>
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 availableLen = max(availableLen, 0); 81 availableLen = max(availableLen, 0);
82 82
83 int* gridLayout = axis.m_sizes.data(); 83 int* gridLayout = axis.m_sizes.data();
84 84
85 if (grid.isEmpty()) { 85 if (grid.isEmpty()) {
86 gridLayout[0] = availableLen; 86 gridLayout[0] = availableLen;
87 return; 87 return;
88 } 88 }
89 89
90 int gridLen = axis.m_sizes.size(); 90 int gridLen = axis.m_sizes.size();
91 ASSERT(gridLen); 91 DCHECK(gridLen);
92 92
93 int totalRelative = 0; 93 int totalRelative = 0;
94 int totalFixed = 0; 94 int totalFixed = 0;
95 int totalPercent = 0; 95 int totalPercent = 0;
96 int countRelative = 0; 96 int countRelative = 0;
97 int countFixed = 0; 97 int countFixed = 0;
98 int countPercent = 0; 98 int countPercent = 0;
99 99
100 float effectiveZoom = style()->effectiveZoom(); 100 float effectiveZoom = style()->effectiveZoom();
101 101
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 result.setPreventResize(TopFrameEdge, m_rows.m_preventResize[0]); 347 result.setPreventResize(TopFrameEdge, m_rows.m_preventResize[0]);
348 result.setAllowBorder(TopFrameEdge, m_rows.m_allowBorder[0]); 348 result.setAllowBorder(TopFrameEdge, m_rows.m_allowBorder[0]);
349 result.setPreventResize(BottomFrameEdge, m_rows.m_preventResize[rows]); 349 result.setPreventResize(BottomFrameEdge, m_rows.m_preventResize[rows]);
350 result.setAllowBorder(BottomFrameEdge, m_rows.m_allowBorder[rows]); 350 result.setAllowBorder(BottomFrameEdge, m_rows.m_allowBorder[rows]);
351 } 351 }
352 352
353 return result; 353 return result;
354 } 354 }
355 355
356 void LayoutFrameSet::layout() { 356 void LayoutFrameSet::layout() {
357 ASSERT(needsLayout()); 357 DCHECK(needsLayout());
358 358
359 if (!parent()->isFrameSet() && !document().printing()) { 359 if (!parent()->isFrameSet() && !document().printing()) {
360 setWidth(LayoutUnit(view()->viewWidth())); 360 setWidth(LayoutUnit(view()->viewWidth()));
361 setHeight(LayoutUnit(view()->viewHeight())); 361 setHeight(LayoutUnit(view()->viewHeight()));
362 } 362 }
363 363
364 unsigned cols = frameSet()->totalCols(); 364 unsigned cols = frameSet()->totalCols();
365 unsigned rows = frameSet()->totalRows(); 365 unsigned rows = frameSet()->totalRows();
366 366
367 if (m_rows.m_sizes.size() != rows || m_cols.m_sizes.size() != cols) { 367 if (m_rows.m_sizes.size() != rows || m_cols.m_sizes.size() != cols) {
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 return SetCursor; 571 return SetCursor;
572 } 572 }
573 if (canResizeColumn(roundedPoint)) { 573 if (canResizeColumn(roundedPoint)) {
574 cursor = columnResizeCursor(); 574 cursor = columnResizeCursor();
575 return SetCursor; 575 return SetCursor;
576 } 576 }
577 return LayoutBox::getCursor(point, cursor); 577 return LayoutBox::getCursor(point, cursor);
578 } 578 }
579 579
580 } // namespace blink 580 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFrameSet.h ('k') | third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698