Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index aca950dfdaef5226338fab9bb65e51c04b10e851..51be19511ac1836cba6b89b1b5d0aa864b942dc8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -1669,7 +1669,7 @@ inline LayoutBox* LayoutBox::lastChildBox() const {
}
inline LayoutBox* LayoutBox::previousSiblingMultiColumnBox() const {
- ASSERT(isLayoutMultiColumnSpannerPlaceholder() || isLayoutMultiColumnSet());
+ DCHECK(isLayoutMultiColumnSpannerPlaceholder() || isLayoutMultiColumnSet());
LayoutBox* previousBox = previousSiblingBox();
if (previousBox->isLayoutFlowThread())
return nullptr;
@@ -1677,13 +1677,13 @@ inline LayoutBox* LayoutBox::previousSiblingMultiColumnBox() const {
}
inline LayoutBox* LayoutBox::nextSiblingMultiColumnBox() const {
- ASSERT(isLayoutMultiColumnSpannerPlaceholder() || isLayoutMultiColumnSet());
+ DCHECK(isLayoutMultiColumnSpannerPlaceholder() || isLayoutMultiColumnSet());
return nextSiblingBox();
}
inline void LayoutBox::setInlineBoxWrapper(InlineBox* boxWrapper) {
if (boxWrapper) {
- ASSERT(!m_inlineBoxWrapper);
+ DCHECK(!m_inlineBoxWrapper);
// m_inlineBoxWrapper should already be nullptr. Deleting it is a safeguard
// against security issues. Otherwise, there will two line box wrappers
// keeping the reference to this layoutObject, and only one will be notified
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698