Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
index ea89beed2ee0e14e83dde22f2ed73a5672d2cd41..d95b80e3f11f2a902f4b2a7cc54095ab617b09c6 100644
--- a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
@@ -63,7 +63,7 @@ LayoutListMarker* LayoutListMarker::createAnonymous(LayoutListItem* item) {
}
LayoutSize LayoutListMarker::imageBulletSize() const {
- ASSERT(isImage());
+ DCHECK(isImage());
const SimpleFontData* fontData = style()->font().primaryFont();
DCHECK(fontData);
if (!fontData)
@@ -135,7 +135,7 @@ void LayoutListMarker::paint(const PaintInfo& paintInfo,
}
void LayoutListMarker::layout() {
- ASSERT(needsLayout());
+ DCHECK(needsLayout());
LayoutAnalyzer::Scope analyzer(*this);
LayoutUnit blockOffset;
@@ -237,7 +237,7 @@ LayoutUnit LayoutListMarker::getWidthOfTextWithSuffix() const {
}
void LayoutListMarker::computePreferredLogicalWidths() {
- ASSERT(preferredLogicalWidthsDirty());
+ DCHECK(preferredLogicalWidthsDirty());
updateContent();
if (isImage()) {
@@ -358,7 +358,7 @@ int LayoutListMarker::baselinePosition(
bool firstLine,
LineDirectionMode direction,
LinePositionMode linePositionMode) const {
- ASSERT(linePositionMode == PositionOnContainingLine);
+ DCHECK_EQ(linePositionMode, PositionOnContainingLine);
if (!isImage())
return m_listItem->baselinePosition(baselineType, firstLine, direction,
PositionOfInteriorLineBoxes);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutListItem.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMedia.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698