third_party/WebKit/Source/core/layout/TextRunConstructor.cpp - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/TextRunConstructor.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/TextRunConstructor.cpp

diff --git a/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp b/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp

index c0ed240d27668c448e241241bedbadf20d6ad1d6..39c24337ed466285551fa53ccbf31e7e3d05d75c 100644

--- a/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp

+++ b/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp

@@ -96,7 +96,7 @@ TextRun constructTextRun(const Font& font,

unsigned length,

const ComputedStyle& style,

TextDirection direction) {

- ASSERT(offset + length <= text->textLength());

+ DCHECK_LE(offset + length, text->textLength());

if (text->hasEmptyText())

return constructTextRunInternal(font, static_cast<const LChar*>(nullptr), 0,

style, direction);