Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ColumnBalancer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
diff --git a/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp b/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
index 8b26465fdfd8dc99e8033211ce2eeae9f1407ec2..2a5d15d9c90c7d5bc2f4e3178467c638232f825a 100644
--- a/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
+++ b/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
@@ -109,8 +109,8 @@ void constructBidiRunsForLine(InlineBidiResolver& topResolver,
bool isNewUBAParagraph) {
// FIXME: We should pass a BidiRunList into createBidiRunsForLine instead
// of the resolver owning the runs.
- ASSERT(&topResolver.runs() == &bidiRuns);
- ASSERT(topResolver.position() != endOfLine);
+ DCHECK_EQ(&topResolver.runs(), &bidiRuns);
+ DCHECK(topResolver.position() != endOfLine);
LineLayoutItem currentRoot = topResolver.position().root();
topResolver.createBidiRunsForLine(endOfLine, override,
previousLineBrokeCleanly);
@@ -133,7 +133,7 @@ void constructBidiRunsForLine(InlineBidiResolver& topResolver,
// nothing about LayoutObject).
LineLayoutItem isolatedInline =
highestContainingIsolateWithinRoot(startObj, currentRoot);
- ASSERT(isolatedInline);
+ DCHECK(isolatedInline);
InlineBidiResolver isolatedResolver;
LineMidpointState& isolatedLineMidpointState =
@@ -171,7 +171,7 @@ void constructBidiRunsForLine(InlineBidiResolver& topResolver,
isolatedResolver.createBidiRunsForLine(endOfLine, NoVisualOverride,
previousLineBrokeCleanly);
- ASSERT(isolatedResolver.runs().runCount());
+ DCHECK(isolatedResolver.runs().runCount());
if (isolatedResolver.runs().runCount())
bidiRuns.replaceRunWithRuns(&isolatedRun.runToReplace,
isolatedResolver.runs());
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ColumnBalancer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698