third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp b/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

index 1a082a529732ddc00c7c0e3ff36f94f5d20640b1..3dc47e6a9c77711d111de5aab9987be0c4abc340 100644

--- a/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

@@ -55,7 +55,7 @@ void LayoutRubyBase::moveChildren(LayoutRubyBase* toBase,

// and appends them to toBase.

DCHECK(toBase);

// Callers should have handled the percent height descendant map.

- ASSERT(!hasPercentHeightDescendants());

+ DCHECK(!hasPercentHeightDescendants());

if (beforeChild && beforeChild->parent() != this)

beforeChild = splitAnonymousBoxesAroundChild(beforeChild);

@@ -73,7 +73,7 @@ void LayoutRubyBase::moveChildren(LayoutRubyBase* toBase,

void LayoutRubyBase::moveInlineChildren(LayoutRubyBase* toBase,

LayoutObject* beforeChild) {

- ASSERT(childrenInline());

+ DCHECK(childrenInline());

DCHECK(toBase);

if (!firstChild())

@@ -101,7 +101,7 @@ void LayoutRubyBase::moveInlineChildren(LayoutRubyBase* toBase,

void LayoutRubyBase::moveBlockChildren(LayoutRubyBase* toBase,

LayoutObject* beforeChild) {

- ASSERT(!childrenInline());

+ DCHECK(!childrenInline());

DCHECK(toBase);

if (!firstChild())