third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp b/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

index c8ed15717c03227d6a481e9778456d18aa663409..fec65554ea813c9a3e8e29674798be52250169cd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

@@ -88,7 +88,7 @@ void LayoutFrameSet::layOutAxis(GridAxis& axis,

}

int gridLen = axis.m_sizes.size();

- ASSERT(gridLen);

+ DCHECK(gridLen);

int totalRelative = 0;

int totalFixed = 0;

@@ -354,7 +354,7 @@ FrameEdgeInfo LayoutFrameSet::edgeInfo() const {

}

void LayoutFrameSet::layout() {

- ASSERT(needsLayout());

+ DCHECK(needsLayout());

if (!parent()->isFrameSet() && !document().printing()) {

setWidth(LayoutUnit(view()->viewWidth()));