Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index ceab308221d680da646754fbb1f3a1bbaa041b4d..995d8b174c29bbca84605184d681ed25a9f8f4d8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -108,11 +108,11 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
public:
LayoutObject* firstChild() const {
- ASSERT(children() == virtualChildren());
+ DCHECK_EQ(children(), virtualChildren());
return children()->firstChild();
}
LayoutObject* lastChild() const {
- ASSERT(children() == virtualChildren());
+ DCHECK_EQ(children(), virtualChildren());
return children()->lastChild();
}
@@ -165,7 +165,7 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
return hasPositionedObjects() ? positionedObjectsInternal() : nullptr;
}
bool hasPositionedObjects() const {
- ASSERT(m_hasPositionedObjects ? (positionedObjectsInternal() &&
+ DCHECK(m_hasPositionedObjects ? (positionedObjectsInternal() &&
!positionedObjectsInternal()->isEmpty())
: !positionedObjectsInternal());
return m_hasPositionedObjects;
@@ -183,7 +183,7 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
: nullptr;
}
bool hasPercentHeightDescendants() const {
- ASSERT(m_hasPercentHeightDescendants
+ DCHECK(m_hasPercentHeightDescendants
? (percentHeightDescendantsInternal() &&
!percentHeightDescendantsInternal()->isEmpty())
: !percentHeightDescendantsInternal());
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698